search

HaxeFoundation / hxcpp

Runtime files for c++ backend for haxe
Other
297 stars 189 forks source link

CI - Host and Localhost tests #1115

Closed Aidan63 closed 4 months ago

Aidan63 commented 4 months ago

The Mac CI has been failing for quite some time now due to a host address resolution test which tries to resolve the localhost. Resolving localhost addresses on mac runners on github actions and azure pipelines has been broken for the last year or so.

https://github.com/actions/runner-images/issues/8649

To work around this I've split up the tests. Using Host.localhost for testing if we can get the localhost address, and new Host("github.com") to test if we can resolve an address. Github should be a pretty safe url to test against.

With this hopefully the CI will be consistently green again!

tobil4sk commented 4 months ago

@Aidan63 Note, testLocalHost() doesn't get run because it has to be called explicitly in the main() method in test/std/Test.hx. Was it omitted intentionally?

Aidan63 commented 4 months ago

Ah, no, that was an oversight on my part then. Must have assumed it was a utest project so any function starting with test would be auto ran. I'll get a fix for it this evening.