search

HaxeFoundation / hxcpp

Runtime files for c++ backend for haxe
Other
295 stars 184 forks source link

CI - UTest2 #1120

Closed Aidan63 closed 2 months ago

Aidan63 commented 2 months ago

@tobil4sk noticed that the change I made to avoid the flakey Mac test wasn't actually running. I assumed the std tests were using utest, but no, the results are manually collected. Initially I was just going to get that new test to run, but then I thought "in for a penny in for a pound" and decided to move those std tests to utest. Then I discovered hxcpp doesn't use utest and instead has a vendored version of the old haxe 3 test stuff.

So here's the hxcpp test suite migrated to UTest2 / utest git.

Aidan63 commented 2 months ago

Seems like these are legitimate failures and I can recreate them, will investigate.

Aidan63 commented 2 months ago

Fixed the few failing tests, both seem to be variants of what seems to be new optimisations done my MSVC triggered by the test suite code changes. I've previously seen this with the GC tests which fail when compiling with C++17 on Windows (https://github.com/HaxeFoundation/hxcpp/issues/1060).

I've worked around this by adding more dummy ?_:Dynamic arguments which seems to cancel out whatever stuff MSVC is doing and gets those tests to pass as they were before.