Resolved multiple warnings on `Apple` targets.

HaxeFoundation / hxcpp

Runtime files for c++ backend for haxe

Other

295 stars 184 forks source link

Resolved multiple warnings on `Apple` targets. #1145

Closed MAJigsaw77 closed 2 weeks ago

MAJigsaw77 commented 2 weeks ago

Replaced sprintf with snprintf because sprintf is deprecated.
Added -Wno-unused-command-line-argument to MacOS toolchain to remove warnings related to unused commands, for example clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument].

tobil4sk commented 2 weeks ago

Added -Wno-unused-command-line-argument to MacOS toolchain to remove warnings related to unused commands, for example clang: warning: argument unused during compilation: '-stdlib=libc++' [-Wunused-command-line-argument].

It would be better to solve the root cause of this warning, which is that -stdlib=libstdc++ should not be passed in when compiling regular C files. It is possible to use cppflag and mmflag tags, e.g.:

https://github.com/HaxeFoundation/hxcpp/blob/17ac6e8a023a8c7a6af0dd8d41f86879e550b5b1/toolchain/iphoneos-toolchain.xml#L35

MAJigsaw77 commented 2 weeks ago

@tobil4sk is it fine now?

tobil4sk commented 2 weeks ago

@MAJigsaw77 Thanks, the mac-toolchain.xml changes look good to me now

MAJigsaw77 commented 2 weeks ago

@tobil4sk Are the changes from iOS and tvOS toolchains fine as well?

MAJigsaw77 commented 2 weeks ago

@tobil4sk Are the changes from iOS and tvOS toolchains fine as well?

Tested them, they work flawlessly

tobil4sk commented 2 weeks ago

@tobil4sk Are the changes from iOS and tvOS toolchains fine as well?

Thanks, they look good to me too