search

HaxeFoundation / hxnodejs

Haxe externs for working with node.js
MIT License
171 stars 63 forks source link

hxnodejs does not fully implement sys.net.Socket (needed for sys.Http) #186

Open theJenix opened 2 years ago

theJenix commented 2 years ago

This could be noise (because haxe.Http exists), or it could be related to #59 ; I noticed that the sys.net.Socket implementation in hxnodejs does not implement the all of the variables and methods defined in https://api.haxe.org/sys/net/Socket.html which means trying to use sys.Http will result in compiler errors. Specifically, it looks like it is missing the output stream variable and the setTimeout and shutdown methods.

neimanpinchas commented 2 years ago

I have as well the same problem, I am ready to implement in if we have basic guidance

neimanpinchas commented 2 years ago

It seems like we must implement a class SocketOutput, and override some methods there. Then add a field output to socket, and initialize it in the constructor to a socketoutput

neimanpinchas commented 2 years ago

https://github.com/HaxeFoundation/hxnodejs/pull/187