HaxeFoundation / intellij-haxe

Haxe plugin for IntelliJ Platform based IDEs (IDEA, Android-Studio)
http://intellij-haxe.org
Apache License 2.0
220 stars 100 forks source link

Cannot use the < key in editor #225

Open rkachowski opened 9 years ago

rkachowski commented 9 years ago

This is a bizarre issue, but I find that with Haxe Support 0.9.2 installed I cannot enter the < character in the editor. This issue affects projects in other languages (tested in objective-c and C)

This issue only appears to manifest when the Haxe Support plugin is enabled, disabling it returns the ability to use the character again. Only the main editor is affected, it is still possible to use this in Preferences and other menus. AFAIK the character isn't bound to any specific shortcut.

AppCode 3.1.5 OSX 10.10.2 JVM 1.6.0_65-b14-466.1-11M4716 x86_64

EBatTiVo commented 9 years ago

What version of IDEA are you using?

You might also try version 0.9.3, which you can pick up in the releases section (https://github.com/TiVo/intellij-haxe/releases). We fixed a problem with unit tests for other languages that only cropped up when haxe support was enabled. I'm not sure that they're related, though.

EBatTiVo commented 9 years ago

A build with the latest sources (0.9.3), with IDEA version 14.0 on Linux, with C/C++ support added works for me...

rkachowski commented 9 years ago

I'm using AppCode 3.1.5, Jetbrains' flavour of IDEA for objc - internally it looks like IDEA OC-139.1400

The same issue appears with the 0.9.3 plugin (on OSX) and is resolved when haxe support is disabled.

EBatTiVo commented 9 years ago

We (as in TiVo devs) are not set up to test AppCode. And I don't know which IDEA release is comparable to 139.1400.

I tested on 139.1117.1, which is IDEA 14.0, by adding in the C/C++ plugin, starting a C project, and writing a "Hello World" program. That worked correctly and I had no issues with the '<' key.

The trouble we fixed last week was with the plugin not checking the file type before it went ahead and created a compile context (see change b77ae4b6c56e63683c077f3c10b933149a2648f1). There is probably something similar that needs to be done in the key handling. The crux of the change was:

+    if (!ModuleUtil.getModuleType(module).equals(HaxeModuleType.getInstance())) {
+      return true;
+    }

You might check the key handling code for something similar. If you can find/fix the issue, we'll be glad to take the pull request. Since we can't reproduce it with our setups, there's not much we can do with it.

aarononeal commented 9 years ago

This also repros on WebStorm 10.0.2.