search

HaxeFoundation / intellij-haxe

Haxe plugin for IntelliJ Platform based IDEs (IDEA, Android-Studio)
http://intellij-haxe.org
Apache License 2.0
219 stars 100 forks source link

Haxe 4: Allow function call expression syntax in #if expressions. #923

Open EricBishton opened 5 years ago

EricBishton commented 5 years ago

Allow #if (ver >= ~/1.5/) #if (ver >= version("1.4.0"))

See https://github.com/HaxeFoundation/haxe/commit/1c6a91fe6abe1d530e6e62126655b5c1a704731b HaxeFoundation/haxe@81c9d2b

Gama11 commented 5 years ago

That was already changed to something else a few commits later. ;)

EricBishton commented 5 years ago

Changed to a version("1.5.0") function call. Ugh. At least it's not a random function call yet; only version is allowed: version(s:String):Int. https://github.com/HaxeFoundation/haxe/commit/81c9d2b98dcf8a1066339b99c3c56b681ca1e753

EricBishton commented 5 years ago

Also, see https://github.com/HaxeFoundation/haxe/commit/78ce9e42b9179409be0da74bd48ac612e433d530 for how the comparison works.