search

HaxeFoundation / neko

The Neko Virtual Machine
https://nekovm.org
Other
553 stars 107 forks source link

Test regexp_matched_num PR #257

Closed RblSb closed 1 year ago

RblSb commented 2 years ago

Want to see green https://github.com/HaxeFoundation/neko/pull/223 Closes #223

RblSb commented 2 years ago

Okay, so that nmatchs groups count doesnt exist in pcredata typedef structure, so it should be ported from hxcpp implementation.

...Can we skip neko part for regex.matchedNum() in https://github.com/HaxeFoundation/haxe/pull/10290, guys?

tobil4sk commented 2 years ago

The code changed slightly when porting to pcre2. I can try to fix it because it wasn't too long ago when I ported it.

RblSb commented 1 year ago

@Simn can this be merged? This closes #223 and unblocks https://github.com/HaxeFoundation/haxe/pull/10290, so maybe one less neko release will be required in future