HaxeFoundation / record-macros

Macro-based ORM (object-relational mapping)
MIT License
49 stars 24 forks source link

Fix tests in haxe4/PHP7 with MySQL #36

Closed bablukid closed 5 years ago

bablukid commented 5 years ago

closes #30

jonasmalacofilho commented 5 years ago

I didn't think adding @:keep in Haxe 4 was appropriate, and it would not fix our problems in Haxe 3. So, I ended up preventing Date.toString from being removed with an initialization macro.

@bablukid, I'm going to go ahead and close this PR, but thanks for showing that these issues were also due to a DCE vs. Dynamic problem.

bablukid commented 5 years ago

Ok, thanks a lot for taking care of this library !