search

HaxeFoundation / try.haxe.org

run Haxe code snippets in your browser
https://try.haxe.org
MIT License
18 stars 10 forks source link

Update to handle namespaced message reporting defines #14

Closed kLabz closed 1 year ago

kLabz commented 1 year ago

This will fix pretty errors for 4.3.1 and for nightlies starting now. See https://github.com/HaxeFoundation/haxe/pull/11142 / https://github.com/HaxeFoundation/haxe/commit/5589eba7cbaa18234e98ffcbf33a32df9aa9e414

We should wait for either 4.3.1 release (early next week I assume) or full list of available nightlies being updated to 5.0.0-alpha.1 (would be nice to have that before 4.3.1 release but with CI being mostly broken it might take a while...)

AlexHaxe commented 1 year ago

can we not just use both sets of defines? earlier Haxe versions would ignore either although now they would only see the dotted defines. and future Haxe versions will ignore the non dotted ones. so we should be fine?

kLabz commented 1 year ago

We could, but the namespace was added mostly for no-color that was too broad and could be used for something else Though that's very unlikely to be an issue on try-haxe..

Am fine with both solutions