search

Hayao0819 / nm-vpngate

A script that makes it easy to connect Network Manager to a VPN Gate
https://www.hayao0819.com/something/nm-vpngate/
Do What The F*ck You Want To Public License
26 stars 2 forks source link

[Feature request] KDialog support. #4

Closed Impeta closed 3 months ago

Impeta commented 2 years ago

It's not any essential of course, but just for consistency's sake on Plasma plus QT-alike environments, would it be any feasible of you implement the option to use KDialog as an alternative from Zenity? Pretty much like the winetricks does, their counterpart GUI toggle being --gui=kdialog.

Hayao0819 commented 2 years ago

OK. I'll add it.

Hayao0819 commented 2 years ago

Almost done. However, it looks bad and only minimal testing.

Please try it here and report it to me.

You can get kdialog with -q, --qt or --gui kdialog option.

https://github.com/Hayao0819/nm-vpngate/tree/ea3b24f1ffc563b0c216dd8a00d6d6548047e971

image

Impeta commented 2 years ago

Thanks so much for your service, as always! The -q and --qt newly-implemented toggles works like a charm, though --gui kdialog seems invalid, as it hangs on and nothing ever imprints in my terminal. You might wish to remove it, per former two functions making it redundant.

Regardless, your script seems to have went haywire. No matter what options I lay on, GUI and whatnot, the output is just as same. Screenshot_20220603_125824

Hayao0819 commented 2 years ago

I already knew the problem, but thought it was just my environment.

I'll try to fix it.

Until that, please use stable version v1.0

Hayao0819 commented 2 years ago

Fixed connection error in 706b6aeb43c0f072e34176ae681cd96cf465ff41

And fixed --git kidalog in 634dbb11d453c01d8550181eae1559c7f95beafa

Please retry it

Impeta commented 2 years ago

Apologizes for the late reply. Everything now works like a charm! Tested --gui with both packages and it goes through! I see also you have curbstomp'd the pretty redundant pop-ups windows about update server list and alike, which is also quite of QOL benefiting change. Fantastic work!

I notice that KDialog isn't as rich on organizing details of each IP like Zenity, nor has got the ability on sorting out per category. I assume this is something you're looking on reformatting better, yes? All things considered, this issue may be closed. :+1:

Hayao0819 commented 2 years ago

Unfortunately, sorting cannot be implemented currnetly.

At this stage, it is implemented only by shell script, so the GUI function depends on the implementation of kdialog. And currently kdialog doesn't support sorting like zenity.

The easiest way is to request this feature to kdialog, but I'm thinking of writing it in Python.