search

HaylLtd / cordova-background-geolocation-plugin

Background and foreground geolocation plugin for Cordova.
Apache License 2.0
57 stars 66 forks source link

feat: add support altitude precision on Android #176

Closed Athorcis closed 10 months ago

Athorcis commented 10 months ago

Add altitude precision on Android, to be able to use on both Android and iOS (since it is already supported on iOS)

HarelM commented 10 months ago

I didn't see any defaults, what would happen when upgrading an existing database?

Athorcis commented 10 months ago

I didn't see any defaults, what would happen when upgrading an existing database?

I assumed that the new columns would be zerofilled but I recon it would be better to have explicit defaults

HarelM commented 10 months ago

Feel free to open a PR with version change in order to shorten the release cycle.

Athorcis commented 10 months ago

Feel free to open a PR with version change in order to shorten the release cycle.

Should I update the minor version number or just the patch version?

HarelM commented 10 months ago

Minor I think.

HarelM commented 8 months ago

@Athorcis have you ran this code? There was a PR here to fix basic syntax that means that this code wasn't ran before (the database update code). Did you add it after testing? I'm not sure what I should be doing with this code if you haven't tested it... The only solution I can think of is reverting this code which I would like to avoid.

Athorcis commented 8 months ago

@HarelM I ran the code of the first commit (which is currently in production), but not the code of the subsequent commits and accordingly 6edc070 seems to be the one introduce a bug

HarelM commented 8 months ago

Ok, thanks for the info! If you happen to run the latest code from main and it works as expected let me know and I'll release a new version.