HaywireInteractive / OnAllFronts-Public

UE5 MilSim FPS / RTS Game (formerly ProjectM)
MIT License
127 stars 24 forks source link

Fix ammo pickup widget showing in drone #907

Closed Leroy231 closed 6 months ago

Leroy231 commented 7 months ago

When in drone and looking at a dead body the ammo pickup widget will show up sometimes (see screenshot below). Note this might only happen on World Partition levels where we move a AWorldPartitionStreamingActor (with a UWorldPartitionStreamingSourceComponent) to where the player is looking to force World Partition to load that cell. It seems there's 2 bugs here:

  1. When in drone you should never see the ammo pickup widget
  2. We should be considering the player close to the ammo source if it's the AWorldPartitionStreamingActor that's overlapping with the pickup sphere. (Use L_LargeMap for world partition)

Image

archimonde1111 commented 7 months ago

I couldn't replicate this bug. Did you play the game in multiplayer? If not, then please try to replicate the bug on this branch with VLOG enabled, and write down repro steps. https://github.com/HaywireInteractive/OnAllFronts/tree/bugfix/Issue-907_AmmoPickupWidgetShowingInDrone

Leroy231 commented 7 months ago

Yes it was multiplayer on City Sample, and using separate process for server. But I tried again on L_Large and couldn't repro. Next time I'm on City Sample I'll try to reproduce and see if I can do it consistently.

Leroy231 commented 6 months ago

I just reproduced this. I was in L_SmallNoObstacles, client net mode, running under one process, with pm.GiveAllSoldiersDrone 1. I first moved in drone a bit away from soldiers, then pressed enter to start combat and eventually this showed up: image