Switch all functional tests to use "Set Console Variable" instead of "Execute Console Command" to set console variables to avoid test pollution from console variables #998
@Leroy231 found that in functional tests if instead of using "Execute Console Command" to set console variables if we use "Set Console Variable from Float/Boolean/Integer" (screenshot below), those console variables will automatically reset at the end of the test so that we won't get test pollution. We should switch to using those in all functional tests.
But keep in mind if we're executing a console command instead of setting a console variable we should still use "Execute Console Command". An example of this is pm.KillSoldiersOnTeam 1, that's a console command, not a variable.
Make sure to rebase before starting as @Leroy231 already fixed one test.
@Leroy231 found that in functional tests if instead of using "Execute Console Command" to set console variables if we use "Set Console Variable from Float/Boolean/Integer" (screenshot below), those console variables will automatically reset at the end of the test so that we won't get test pollution. We should switch to using those in all functional tests.
But keep in mind if we're executing a console command instead of setting a console variable we should still use "Execute Console Command". An example of this is
pm.KillSoldiersOnTeam 1, that's a console command, not a variable.Make sure to rebase before starting as @Leroy231 already fixed one test.