search

HazAT / badge

Add a badge to your app icon
MIT License
966 stars 87 forks source link

Make shield service dynamic #63

Closed rkrim closed 6 years ago

HazAT commented 6 years ago

Hey, @TwiterZX is this PR finished? It's a nice abstraction but it's not really dynamic like in adding a command line parameter or something?!

rkrim commented 6 years ago

Doesn’t seem to be finished.

First intention was to make badge less attached to shields.io because it was not working yesterday. As I didn’t find another service to rely on, I didn’t knew what kind of model to implement. So I just made variable more generic, and introduced one for the service name to ease the work for improving. I kept the dynamic word in the commit title because of the introduction of this variable😀.

Regards

rkrim commented 6 years ago

Ok the commit title should be
Make shield service name dynamic.

On 18 December 2017 at 19:51:28, Daniel Griesser (notifications@github.com(mailto:notifications@github.com)) wrote:

Hey, @TwiterZX(https://github.com/twiterzx) is this PR finished? It's a nice abstraction but it's not really dynamic like in adding a command line parameter or something?!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub(https://github.com/HazAT/badge/pull/63#issuecomment-352522718), or mute the thread(https://github.com/notifications/unsubscribe-auth/AAt5gOYyFUzZ9sr5HRGqNTXEWfabbbmDks5tBrQwgaJpZM4RFuGi).

HazAT commented 6 years ago

Thx 👍 Every refactoring is a good refactoring 💃