search

HazAT / badge

Add a badge to your app icon
MIT License
966 stars 87 forks source link

Crashes when using fast lane and Carthage #66

Closed nicollis closed 6 years ago

nicollis commented 6 years ago

Crashes with the error below. Works when I delete the problem files from the checkouts folder.

Would be great if I could scope the Fastlane plugin to only change a defined assets folder

[14:06:24]: `identify -format %m %w %h %b ./Carthage/Checkouts/facebook-ios-sdk/samples/Scrumptious/scrumptious/Images.xcassets/AppIcon.appiconset/Icon-29.png[0]` failed with error:
identify: CgBI: unhandled critical chunk `./Carthage/Checkouts/facebook-ios-sdk/samples/Scrumptious/scrumptious/Images.xcassets/AppIcon.appiconset/Icon-29.png' @ error/png.c/MagickPNGErrorHandler/1711.
jschmid commented 6 years ago

@nicollis you can already select the folder you want, with something like that:

    add_badge(
      shield: "v-1.2-orange",
      no_badge: true,
      glob: "/MyProject/Assets.xcassets/AppIcon.appiconset/*.png",
    )
HazAT commented 6 years ago

Closing this since the issue seems to be resolved with glob option.