search

HazAT / badge

Add a badge to your app icon
MIT License
966 stars 87 forks source link

Remove curb dependencies #70

Closed giginet closed 3 years ago

giginet commented 6 years ago

Currently, this plugin depends on curb.

But I think this dependency doesn't make sense. We can use open-uri instead.

To install curb, we have to install libcurl. It's not installed on some environments.

I checked following situations:

sraka1 commented 4 years ago

@HazAT any reason this hasn't been merged in?

mortenholmgaard commented 4 years ago

@HazAT Please take a look at this. I would love to use Badge on multiple project also on Fastlane for Android run from Windows - but there curb is very complicated to get installed!

anas10 commented 4 years ago

🆙 would love to use this too but curb is causing issues when we try to install it on different systems.

Any reason why this PR is not considered? @HazAT

casperriboe commented 3 years ago

So is it correctly understood that that curb is no longer maintained for macOS? Considering that it makes sense to ditch curb.

onevcat commented 3 years ago

This change breaks our proxy setting in terminal. (the http_proxy and https_proxy environment value), without which we cannot connect to an external website like shields.io.

The previous version works well.