search

Hazel1603 / pe

0 stars 0 forks source link

UI Component not updated? #26

Open Hazel1603 opened 4 years ago

Hazel1603 commented 4 years ago

Cannot see your code but I'd expect other views like ModuleListPanel and MeetingListPanel and MeetingViewPanel to be included. It'd be good to add to demonstrate the UI Component better.

nus-se-bot commented 4 years ago

Team's Response

Our team had this conversation about including the new panels however, adding the new panels would make the overall diagram very messy which may impede understanding. Hence, we decide to stick with the PersonsPanel to illustrate the pattern however we accept that we could have been more explicit with the panels we have left out.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Medium]

Reason for disagreement: Even if the diagram was not modified, there should be some mention of how the other panels would integrate into the code. Your description is largely the same as that from AB3. I think this affects the understanding users have of your code and affects the quality of documentation.