HazyResearch / H3

Language Modeling with the H3 State Space Model
Apache License 2.0
515 stars 54 forks source link

Question about methodology used for evaluating FlashConv against cuFFT #23

Closed sylee0124 closed 1 year ago

sylee0124 commented 1 year ago

Hi, I have a question related to a Figure in the H3 paper. In Figure 2, it shows performance evaluation of FlashConv against cuFFT and attention. Is it correct to think that it's comparing all operations in H3, including qkv computation and kernel generations and not just FFTconv related operation (FFTconv + elementwise multiplication + residual computation)? image

tridao commented 1 year ago

Here we're just considering the FFTConv related operations (fft, pointwise multiplication, inverse fft, residual computation).

sylee0124 commented 1 year ago

Thanks for the reply!👍