Requirements may not be up to date

HazyResearch / butterfly

Butterfly matrix multiplication in PyTorch

Apache License 2.0

164 stars 31 forks source link

Requirements may not be up to date #18

Closed iacolippo closed 3 years ago

iacolippo commented 3 years ago

Hi,

Thanks for the wonderful package! I was trying to install it with a Pytorch 1.7.1 but I get a bunch of errors during the compilation of the CUDA extension. After inspection of the source, I believe that the new implementation only works with Pytorch >1.8 (with which I could successfully install).

The requirements still show >=1.3 though, it might be good to update them or specify this in the README.

tridao commented 3 years ago

Thanks! I've updated the requirements to pytorch>=1.8