Xiao bugfix - Githubissues

HazyResearch / ddlog

Compiler for writing DeepDive applications in a Datalog-like language — ⚠️🚧🛑 REPO MOVED TO DEEPDIVE 👇🏿

https://github.com/HazyResearch/deepdive/tree/master/compiler/ddlog

19 stars 4 forks source link

Xiao bugfix #64

Closed xiaoling closed 9 years ago

xiaoling commented 9 years ago

Fixed a bug in DeepDiveLogParser.scala (9df3e26). Added a input_batch_size parameter in DeepDiveLogCompiler.scala (384488c). Also adjusted test cases to reflect the above change.

xiaoling commented 9 years ago

@netj I recreated a pull request to remove the duplicate commits and added some lines to the test cases.

netj commented 9 years ago

Looks good.

Eventually, the input_batch_size config will go away as we improve DeepDive, but I can understand you want control over that for now.
In the future, you can just do a git push -f to the same branch instead of recreating the pull request.

netj commented 9 years ago

@xiaoling Actually, I realize $INPUT_BATCH_SIZE is now required to be set in the environment. Can you create a PR on deepdive as well fixing deepdive-run to set a reasonable default value, similar to $PARALLELISM?