HazyResearch / flash-fft-conv

FlashFFTConv: Efficient Convolutions for Long Sequences with Tensor Cores
Apache License 2.0
277 stars 27 forks source link

Can we install FlashFFTConv by pip? #13

Closed Hambaobao closed 10 months ago

Hambaobao commented 10 months ago

Hi, thanks for your great work. Can we directly install FlashFFTConv through pip, for example, using a command like: pip install git+https://github.com/HazyResearch/flash-fft-conv.git?

Hambaobao commented 10 months ago

Hi, thanks for your great work. Can we directly install FlashFFTConv through pip, for example, using a command like: pip install git+https://github.com/HazyResearch/flash-fft-conv.git?

I tried pip install git+https://github.com/HazyResearch/flash-fft-conv.git#subdirectory=csrc/flashfftconv, and it seems worked.😂

DanFu09 commented 10 months ago

Cool! I’ll add it to the Readme!

On Wed, Dec 27, 2023 at 6:06 AM Zhang Lei @.***> wrote:

Hi, thanks for your great work. Can we directly install FlashFFTConv through pip, for example, using a command like: pip install git+https://github.com/HazyResearch/flash-fft-conv.git?

I tried pip install git+ https://github.com/HazyResearch/flash-fft-conv.git#subdirectory=csrc/flashfftconv, and it seems worked.😂

— Reply to this email directly, view it on GitHub https://github.com/HazyResearch/flash-fft-conv/issues/13#issuecomment-1870290364, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABDDIITPRHA7PNDNSXO5KX3YLQMM3AVCNFSM6AAAAABBEKN4WGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZQGI4TAMZWGQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Hambaobao commented 10 months ago

Cool! I’ll add it to the Readme! …

Sorry, my mistake, it seems like it's still not installed correctly. 🤣

Hambaobao commented 10 months ago

Cool! I’ll add it to the Readme! …

Sorry, my mistake, it seems like it's still not installed correctly. 🤣

Alright, I have solved it.😬 We need to do two steps:

  1. pip install git+https://github.com/HazyResearch/flash-fft-conv.git#subdirectory=csrc/flashfftconv;
  2. pip install git+https://github.com/HazyResearch/flash-fft-conv.git;

Done! ✨