search

HazyResearch / flyingsquid

More interactive weak supervision with FlyingSquid
Apache License 2.0
313 stars 21 forks source link

_triplet_method_preprocess seems to be missing break statements #4

Closed coulls closed 4 years ago

coulls commented 4 years ago

In this loop (https://github.com/HazyResearch/flyingsquid/blob/master/flyingsquid/label_model.py#L283-L288), both the inner and outer loop are escaped once a triplet is found.

Here (https://github.com/HazyResearch/flyingsquid/blob/master/flyingsquid/label_model.py#L305-L308) and in a mirrored loop below, there is no escape for the outer loop. That seems to be a bug as it means the entire inner loop will continue to be evaluated over and over even if a triplet was discovered.

DanFu09 commented 4 years ago

Thanks for the bug report - I saw the bug right after your last issue too :)