search

HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

Add a custom MLflow model for Fonduer #407

Closed HiromuHota closed 4 years ago

HiromuHota commented 4 years ago

This will close #259.

codecov-io commented 4 years ago

Codecov Report

Merging #407 into master will increase coverage by 0.10%. The diff coverage is 83.09%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   82.37%   82.47%   +0.10%     
==========================================
  Files          86       87       +1     
  Lines        4357     4503     +146     
  Branches      806      824      +18     
==========================================
+ Hits         3589     3714     +125     
- Misses        576      594      +18     
- Partials      192      195       +3
Flag Coverage Δ
#unittests 82.47% <83.09%> (+0.10%) :arrow_up:
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/fonduer/utils/fonduer_model.py 83.09% <83.09%> (ø)
src/fonduer/utils/utils_udf.py 81.41% <0.00%> (+0.64%) :arrow_up:
src/fonduer/supervision/labeler.py 70.37% <0.00%> (+0.90%) :arrow_up:
src/fonduer/candidates/models/candidate.py 74.57% <0.00%> (+1.69%) :arrow_up:
src/fonduer/candidates/models/mention.py 69.49% <0.00%> (+1.69%) :arrow_up:
lukehsiao commented 4 years ago

Do you want to include this in v0.8.2?

HiromuHota commented 4 years ago

Although this PR would not introduce a breaking change, v0.8.2 does not have to wait for this. I'm targeting at v0.9.0.

codecov-commenter commented 4 years ago

Codecov Report

Merging #407 into master will increase coverage by 0.73%. The diff coverage is 98.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   82.44%   83.17%   +0.73%     
==========================================
  Files          86       88       +2     
  Lines        4385     4548     +163     
  Branches      812      837      +25     
==========================================
+ Hits         3615     3783     +168     
+ Misses        582      572      -10     
- Partials      188      193       +5
Flag Coverage Δ
#unittests 83.17% <98.36%> (+0.73%) :arrow_up:
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)
src/fonduer/utils/utils_udf.py 81.13% <95.83%> (-0.28%) :arrow_down:
src/fonduer/packaging/fonduer_model.py 98.73% <98.73%> (ø)
src/fonduer/packaging/__init__.py 100.00% <100.00%> (ø)
src/fonduer/candidates/models/mention.py 74.57% <0.00%> (+6.77%) :arrow_up:
src/fonduer/candidates/models/candidate.py 79.66% <0.00%> (+6.77%) :arrow_up: