HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

Page assigned by VisualLinker is 1-based indexing while docs says 0-based #441

Closed HiromuHota closed 4 years ago

HiromuHota commented 4 years ago

Describe the bug

According to the docs,

Page indexes start at 0.

However, the page assigned by VisualLinker is 1-based indexing.

To Reproduce

It is trivial. You can see assertions like assert sentence.page == [1, 1, 1] at test_parser.py for example.

Expected behavior

This is ether a documentation error or implementation error.

Environment (please complete the following information):

Additional context Add any other context about the problem here.