HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

remove self.logger #462

Closed senwu closed 4 years ago

senwu commented 4 years ago

Description of the problems or issues

Is your pull request related to a problem? Please describe. Some code use self.logger which is not expected.

Description of the proposed changes

Use global logger for each python file if needed.

Test plan

No test needed.

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #462 into master will increase coverage by 0.04%. The diff coverage is 40.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   83.28%   83.32%   +0.04%     
==========================================
  Files          88       88              
  Lines        4564     4563       -1     
  Branches      837      837              
==========================================
+ Hits         3801     3802       +1     
+ Misses        572      571       -1     
+ Partials      191      190       -1     
Flag Coverage Δ
#unittests 83.32% <40.00%> (+0.04%) :arrow_up:
Impacted Files Coverage Δ
src/fonduer/parser/visual_linker.py 84.18% <23.07%> (ø)
src/fonduer/parser/lingual_parser/spacy_parser.py 81.81% <33.33%> (-0.11%) :arrow_down:
src/fonduer/utils/udf.py 88.67% <83.33%> (ø)
src/fonduer/candidates/models/span_mention.py 76.63% <0.00%> (+1.86%) :arrow_up: