HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

Add tests for `matchers.py` #472

Closed HiromuHota closed 4 years ago

HiromuHota commented 4 years ago

Description of the problems or issues

Is your pull request related to a problem? Please describe.

Towards #380.

Does your pull request fix any issue.

Towards #380.

Description of the proposed changes

This PR adds more tests.

Test plan

This PR adds more tests.

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #472 into master will increase coverage by 1.49%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   84.33%   85.82%   +1.49%     
==========================================
  Files          88       88              
  Lines        4557     4557              
  Branches      847      847              
==========================================
+ Hits         3843     3911      +68     
+ Misses        527      464      -63     
+ Partials      187      182       -5     
Flag Coverage Δ
#unittests 85.82% <ø> (+1.49%) :arrow_up:
Impacted Files Coverage Δ
src/fonduer/candidates/models/span_mention.py 82.24% <0.00%> (+7.47%) :arrow_up:
src/fonduer/candidates/matchers.py 97.31% <0.00%> (+32.25%) :arrow_up: