HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

make check fails because of an isort's breaking change #474

Closed HiromuHota closed 4 years ago

HiromuHota commented 4 years ago

Description of the bug

GitHub Actions failed https://github.com/HazyResearch/fonduer/runs/839099081 because isort's breaking change.

isort has been updated 7/4 (https://github.com/timothycrosley/isort/blob/master/CHANGELOG.md#500-penny---july-4-2020) v5.0.0 introduced many breaking changes and the following change broke fonduer's testing code.

To Reproduce

Steps to reproduce the behavior:

  1. Update isort v5.0.0+
  2. Execute make check

Expected behavior

Tests pass.

Error Logs/Screenshots

isort -rc -c src/
usage: isort [-h] [--src SRC_PATHS] [-a ADD_IMPORTS] [--ac] [--af]
             [-b KNOWN_STANDARD_LIBRARY]
             [--extra-builtin EXTRA_STANDARD_LIBRARY] [-c] [--ca] [--cs] [-d]
             [--df] [--ds] [-e] [-f KNOWN_FUTURE_LIBRARY] [--fas] [--fass]
             [--ff FROM_FIRST] [--fgw [FORCE_GRID_WRAP]] [--fss] [-i INDENT]
             [-j JOBS] [-k] [--lai LINES_AFTER_IMPORTS]
             [--lbt LINES_BETWEEN_TYPES] [--le LINE_ENDING] [--ls]
             [-m {GRID,VERTICAL,HANGING_INDENT,VERTICAL_HANGING_INDENT,VERTICAL_GRID,VERTICAL_GRID_GROUPED,VERTICAL_GRID_GROUPED_NO_COMMA,NOQA,VERTICAL_HANGING_INDENT_BRACKET,VERTICAL_PREFIX_FROM_MODULE_IMPORT,0,1,2,3,4,5,6,7,8,9}]
             [-n] [--nis] [--nlb NO_LINES_BEFORE] [-o KNOWN_THIRD_PARTY]
             [--ot] [--dt] [-p KNOWN_FIRST_PARTY] [-q] [--rm REMOVE_IMPORTS]
             [--rr] [-s SKIP] [--sd DEFAULT_SECTION] [--sg SKIP_GLOB] [--sl]
             [--nsl SINGLE_LINE_EXCLUSIONS] [--sp SETTINGS_PATH]
             [-t FORCE_TO_TOP] [--tc] [--up] [-V] [-v]
             [--virtual-env VIRTUAL_ENV] [--conda-env CONDA_ENV] [--vn]
             [-l LINE_LENGTH] [--wl WRAP_LENGTH] [--ws] [--case-sensitive]
             [--filter-files] [--py {all,2,27,3,35,36,37,38,39,auto}]
             [--profile {black,django,pycharm,google,open_stack,plone,attrs,hug}]
             [--interactive] [--old-finders] [--show-config]
             [files [files ...]]
isort: error: unrecognized arguments: -rc
Makefile:19: recipe for target 'check' failed
make: *** [check] Error 2
##[error]Process completed with exit code 2.

Environment (please complete the following information)

Additional context

Add any other context about the problem here.

HiromuHota commented 4 years ago

These changes also affect Fonduer: