HazyResearch / fonduer

A knowledge base construction engine for richly formatted data
https://fonduer.readthedocs.io/
MIT License
409 stars 77 forks source link

Fix #469 #480

Closed YasushiMiyata closed 4 years ago

YasushiMiyata commented 4 years ago

Description of the problems or issues

Is your pull request related to a problem? Please describe. 'get_max_row_num' is missing in 'fonduer.utils.data_model_utils.tabular'

Does your pull request fix any issue. Fix #469

Description of the proposed changes

Add get_max_row_num to tabular.py and revise the test code in test_tabular.py.

Test plan

Have revised the test code in test_tabular.py and done unit test.

Checklist

codecov-commenter commented 4 years ago

Codecov Report

Merging #480 into master will increase coverage by 0.05%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #480      +/-   ##
==========================================
+ Coverage   85.77%   85.83%   +0.05%     
==========================================
  Files          88       88              
  Lines        4554     4559       +5     
  Branches      847      848       +1     
==========================================
+ Hits         3906     3913       +7     
+ Misses        465      464       -1     
+ Partials      183      182       -1     
Flag Coverage Δ
#unittests 85.83% <100.00%> (+0.05%) :arrow_up:
Impacted Files Coverage Δ
src/fonduer/utils/data_model_utils/tabular.py 100.00% <100.00%> (ø)
src/fonduer/parser/visual_linker.py 84.18% <0.00%> (+0.93%) :arrow_up: