Open HiromuHota opened 4 years ago
Unlike other methods (eg Featurizer.drop_keys() and Featurizer.upsert_keys(), Featurizer.get_keys() does not honor candidate classes in context but returns all feature keys no matter which candidate class they are associated with. This is confusing.
Featurizer.drop_keys()
Featurizer.upsert_keys()
Featurizer.get_keys()
See https://github.com/HazyResearch/fonduer/issues/511#issuecomment-696618392 for how this actually confused a user.
This is a design error.
These methods should behave similarly. Either
N/A
Add any other context about the problem here.
Description of the bug
Unlike other methods (eg
Featurizer.drop_keys()andFeaturizer.upsert_keys(),Featurizer.get_keys()does not honor candidate classes in context but returns all feature keys no matter which candidate class they are associated with. This is confusing.See https://github.com/HazyResearch/fonduer/issues/511#issuecomment-696618392 for how this actually confused a user.
To Reproduce
This is a design error.
Expected behavior
These methods should behave similarly. Either
Error Logs/Screenshots
N/A
Environment (please complete the following information)
Additional context
Add any other context about the problem here.