HazyResearch / hgcn

Hyperbolic Graph Convolutional Networks in PyTorch.
602 stars 109 forks source link

issues of "def split_data()" #27

Open jingweio opened 3 years ago

jingweio commented 3 years ago

I notice that "split_data()" in the script of "hgcn/utils/data_utils.py" sperates dataset into "pos" and "neg" for sampling trn-val-tst uniformly. It is ok for the dataset: "DISEASE" containing only 2 classes but not ok for dataset: "AIRPORT" containing 4 classes. But I notice that in the function of "load_data_nc()" wrote in "hgcn/utils/data_utils.py" use "split_data()" to create splits for both "DISEASE" and "AIRPORT" which may results in 1) repeated samlples in each split and 2) overlapping between splits.