HazyResearch / mindbender

Tools for iterative knowledge base development with DeepDive
117 stars 31 forks source link

tags.json permission problems #3

Open zifeishan opened 9 years ago

zifeishan commented 9 years ago

We had a use case when user A on a server S started mindtagger for labeling, and user C visited the labeling interface and tags.json is generated.

At time T, user B logged into the same server S and started mindtagger in the same folder. However, user B do not have permission to change the tags.json file, so when C continue to do labeling, changes cannot be saved to tags.json, however from the frontend C cannot tell there is a problem in labeling. The tags.json file kept as it was in time T, since no additional changes could be saved.

Possible solutions might be force tags.json writable to everyone, or check permission problems and report (to frontend?)

netj commented 9 years ago

This is a very nasty GUI bug indeed. However I think the proper way (and the only way) to share mindtagger is to have a dedicated user (either A or B, or even D) run the server and let everyone access via the browser. Besides, even though users A and B may still be able to run the server by relaxing tags.json's permission, they must not run it at the same time (on different PORTs) because mindtagger will never read each other's modifications. The GUI should definitely be fixed to display an error when the changes cannot be saved by the server, but I'm unsure about the latter part of this problem. Perhaps we should lock a task dir or tags,json when a mindtagger server loads it to prevent any data loss/race.