Bug in dataset caching - Githubissues

HazyResearch / safari

Convolutions for Sequence Modeling

Apache License 2.0

848 stars 70 forks source link

Bug in dataset caching #18

Closed PgLoLo closed 1 year ago

PgLoLo commented 1 year ago

There seems to be a bug in synthetic dataset ICLDataModule caching system: self.data_dir is not check on None before caching dataset. Because of that standard runs that are listed in experiments.md, for example this one:

python -m train experiment=synthetics/associative_recall/transformer

fails with null pointer exception.

I fixed it.

Zymrael commented 1 year ago

Thanks!