Open renll opened 9 months ago
Thanks for the great work. I think the implementation of SMA has some mistakes.
But it seems that this trick is lacked in the zoology implementation: https://github.com/HazyResearch/zoology/blob/dd43c72fe455fedf283cd73e037addc0e0d3be03/zoology/mixers/selective.py#L209
Thanks for the great work. I think the implementation of SMA has some mistakes.
But it seems that this trick is lacked in the zoology implementation: https://github.com/HazyResearch/zoology/blob/dd43c72fe455fedf283cd73e037addc0e0d3be03/zoology/mixers/selective.py#L209