search

HdrHistogram / hdrhistogram-go

A pure Go implementation of Gil Tene's HDR Histogram.
MIT License
435 stars 64 forks source link

Max bugfix #15

Closed adrianco closed 8 years ago

adrianco commented 8 years ago

Max needs to return the upper bound of the top bucket to be more than the actual maximum value seen.

codahale commented 8 years ago

Good find, but this breaks the build. Can you fix the tests?

adrianco commented 8 years ago

Sorry, I ended up including my addition to hdr as well as the fix of the test in the same commit

codahale commented 8 years ago

No worries — thanks for the fix!

adrianco commented 8 years ago

I'm modifying metrics to allow entire distributions to be extracted, not just percentiles. Needed the extra method in hdr. I've got versions for codahale/metrics and for go-kit/metrics.

Thanks for the quick merge!