bug in validation errors - dev and staging

[julianagle]

Jeff noticed this error over the weekend when testing the contact info survey:

I got this error when putting in the wrong phone number…it says Zip code instead of phone number:

http://screencast.com/t/C9hS0GS9j

This was true for each of the phone number fields

However when I checked it this morning, I get the correct validation error for the phone numbers, but when I enter an incorrect zip code, I get an error that says it should be a phone number. I checked our zz test survey, and it appears that all of the validation error messages are now just the phone number message.

[julianagle]

here is the link to the test survey

https://redcap-dev.health-eheartstudy.org/surveys/?s=AKzvZt

[tparsnick]

Julie, This is strange, we need to determine if it redcap or something we did in re-skinning. Please duplicate the test survey on our non-heh redcap at

http://185-rdcap32-cl1/redcap/ http://185-rdcap32-cl1/redcap/ and see if the problem exists there as well.

---

From: julianagle [mailto:notifications@github.com] Sent: Monday, February 25, 2013 9:31 AM To: UCSF-DMG/redcap Subject: [redcap] bug in validation errors - dev and staging (#42)

Jeff noticed this error over the weekend when testing the contact info survey:

I got this error when putting in the wrong phone number...it says Zip code instead of phone number:

http://screencast.com/t/C9hS0GS9j

This was true for each of the phone number fields

However when I checked it this morning, I get the correct validation error for the phone numbers, but when I enter an incorrect zip code, I get an error that says it should be a phone number. I checked our zz test survey, and it appears that all of the validation error messages are now just the phone number message.

Reply to this email directly or view it on GitHub https://github.com/UCSF-DMG/redcap/issues/42 .

https://github.com/notifications/beacon/7PLypKeqQtVZNpQ1_KPxU6Okb4xepqS Ps2etWliB58gCXLTIAwjgipqDKeVpCx4-.gif

[julianagle]

@tparsnick Done, the problem does not exist on the non-HeH redcap so looks like it was introduced in the re-skinning. Here is the survey:

http://185-rdcap32-cl1/redcap/surveys/?s=WUDNXm

[tparsnick]

Thanks

---

From: julianagle [mailto:notifications@github.com] Sent: Monday, February 25, 2013 11:00 AM To: UCSF-DMG/redcap Cc: Parsnick, Todd Subject: Re: [redcap] bug in validation errors - dev and staging (#42)

@tparsnick https://github.com/tparsnick Done, the problem does not exist on the non-HeH redcap so looks like it was introduced in the re-skinning. Here is the survey:

http://185-rdcap32-cl1/redcap/surveys/?s=WUDNXm

Reply to this email directly or view it on GitHub https://github.com/UCSF-DMG/redcap/issues/42#issuecomment-14066009 .

https://github.com/notifications/beacon/7PLypKeqQtVZNpQ1_KPxU6Okb4xepqS Ps2etWliB58gCXLTIAwjgipqDKeVpCx4-.gif

[kimburgia]

I've been testing this using the public survey link from the dev server (https://redcap-dev.health-eheartstudy.org/surveys/?s=XKStpA) and I was not able to recreate the issue.

@tparsnick - does this mean we can close this issue?

[kimburgia]

I've also thoroughly checked the zip code and had no problems. Perhaps it was triggering from a phone error that hadn't been deleted in a text box below? In any case, I cannot recreate this.

[kimburgia]

OK I guess I spoke too soon about the zip code?

[kimburgia]

It still accepts a standard zip code though:

[kimburgia]

Reloaded the page, got the proper alert.

I have no idea what is going on with this...

[kimburgia]

And was finally able to recreate the original phone issue...

Sorry for the zillion posts - I'm going to stop messing with this and let you guys look at it.

[kimburgia]

I was able to recreate the zip code error on the skinned test survey: https://redcap-stage.health-eheartstudy.org/surveys/?s=dHT9eN

Was unable to try the unskinned redcap (http://185-rdcap32-cl1/redcap/surveys/?s=WUDNXm didn't work)

[kimburgia]

It looks like the email fields are having problems too...

From 1-3b Emergency Contact Information - https://redcap-dev.health-eheartstudy.org/surveys/?s=6dvmks

[kimburgia]

Worked alright in the test survey:

[tparsnick]

!Notes for todd only. Contact info survey is at

http://localhost/redcap/surveys/?s=XKStpA https://redcap-dev.health-eheartstudy.org/surveys/?s=HXVzrL

[tparsnick]

I rolled back REDcap to original unchanged code for 4.15.2. And had the same issues with zip and phone. If you enter alpha for zip and then fix it and go to the phone and enter alpha for phone then you get a zip error. This appears to be a problem at the base of REDcap that might be fixed w/ future upgrades.

@julianagle Can you please look through the release notes since 4.15.2 and the google mail to see if this issue was seen by others and/or fixed in later releases.

[julianagle]

Yes, although it's strange because it was working correctly before, wasn't it? I don't remember it being a problem before. I will check...

[julianagle]

This might be it:

https://iwg.devguard.com/trac/redcap/wiki/VersionToVersionDoc

Version 5.2.0 - codename "Apple Fritter" (released 02/22/2013

Bug fix: When two fields are adjacent on a form/survey and both have field validation, then if the first field displays the validation error pop-up after entering a value for it but then has its value corrected, and then the second field displays the validation error pop-up after entering a value for it, then the pop-up message will be incorrect and will mistakenly display the error message for the previous field.

[tparsnick]

@julianagle Cool thanks. That looks like the problem!

[julianagle]

Great! Glad I found it and they have fixed it....