HeYijia / svo_edgelet

A more robust SVO with edgelet feature
GNU General Public License v2.0
434 stars 175 forks source link

some errors #2

Closed ghost closed 6 years ago

ghost commented 6 years ago

Hi, There are some errors when I ran it,I can't find solutions of this case.Can you tell me what's wrong with it ?Thank you! What's your opencv version? 2017-10-25 23 20 52

HeYijia commented 6 years ago

I am sorry for that I forget the findEssentialMat() included in my code have the same name with opencv2 code. I will fix this bug today.

ghost commented 6 years ago

Thank you very much,but there are still some problems.What's the version of opencv?And I couldn't find the header file of 'internal.hpp'.

/home/daohang/svo_edgelet-master/include/precomp.hpp:52:37: fatal error: opencv2/core/internal.hpp: No such file or directory

include "opencv2/core/internal.hpp"

                                 ^
HeYijia commented 6 years ago

I use opencv2.13. Do you use opencv3 ?

ghost commented 6 years ago

yes,I use opencv3.1.It seems a bit incompatible with the previous version.

cumtchenchang commented 6 years ago

I also encountered similar error, I use openv3.2. c@cc-B250-HD3:~/code/svo_edgelet/build$ make [ 2%] Building CXX object CMakeFiles/svo.dir/src/feature_detection.cpp.o /home/cc/code/svo_edgelet/src/feature_detection.cpp: In function ‘void svo::feature_detection::saveMatToCsv(cv::Mat, std::__cxx11::string)’: /home/cc/code/svo_edgelet/src/feature_detection.cpp:28:40: error: invalid conversion from ‘const char’ to ‘int’ [-fpermissive] outputFile << cv::format(data,"CSV")<<std::endl; ^ In file included from /opt/ros/kinetic/include/opencv-3.2.0-dev/opencv2/core.hpp:3214:0, from /opt/ros/kinetic/include/opencv-3.2.0-dev/opencv2/opencv.hpp:52, from /home/cc/code/svo_edgelet/include/svo/global.h:28, from /home/cc/code/svo_edgelet/include/svo/feature_detection.h:20, from /home/cc/code/svo_edgelet/src/feature_detection.cpp:17: /opt/ros/kinetic/include/opencv-3.2.0-dev/opencv2/core/operations.hpp:371:16: note: initializing argument 2 of ‘cv::Ptr cv::format(cv::InputArray, int)’ Ptr format(InputArray mtx, int fmt) ^ /home/cc/code/svo_edgelet/src/feature_detection.cpp: In member function ‘virtual void svo::feature_detection::EdgeDetector::detect(svo::Frame, const ImgPyr&, double, svo::Features&)’: /home/cc/code/svo_edgelet/src/feature_detection.cpp:545:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] int a = (n>edge_list.size())? edge_list.size():n; ^ CMakeFiles/svo.dir/build.make:302: recipe for target 'CMakeFiles/svo.dir/src/feature_detection.cpp.o' failed make[2]: [CMakeFiles/svo.dir/src/feature_detection.cpp.o] Error 1 CMakeFiles/Makefile2:67: recipe for target 'CMakeFiles/svo.dir/all' failed make[1]: [CMakeFiles/svo.dir/all] Error 2 Makefile:83: recipe for target 'all' failed make: *** [all] Error 2

supersheepcy commented 6 years ago

您好,我遇到了和上面一样的问题,请问cv::format函数应该怎么修改呢?

zxp771 commented 6 years ago

Hi @cumtchenchang @SiuKeungm

Sorry to disturb you. Have you figured out those problems in ROS kinetic(my original version opencv is 3.3.1)? Do you implement this algorithm in ROS?

zhangxiaoya commented 5 years ago

@supersheepcy opencv版本不一样,参考这里修改一下https://answers.opencv.org/question/73223/cant-create-csv-file/