search

Headstorm / foundry-ui

Foundry-UI is a React UI Library built which prioritizes theming, accessibility, and performance. Fully typed with TypeScript, animated by react-spring, themed with styled-components, and made accessible by polished and jest-axe.
Apache License 2.0
16 stars 43 forks source link

Button | Change -webkit-appearance to none to fix button anchors on Safari #405

Closed aVileBroker closed 1 year ago

aVileBroker commented 2 years ago

For buttons with the as prop for the container changing it from a button to an a, keeps the role as button as expected, but safari forces button appearance to the anchor because of that role.

Fix is to set -webkit-appearance: none; on all button containers (we'll always want our styles)

Safari:

image

Chrome image

asheerrizvi commented 2 years ago

@aVileBroker have opened a PR for this, lmk if this is ok?

406

HeadstormOps commented 2 years ago

:tada: This issue has been resolved in version 1.20.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket: