Some missing opcodes

[imyxh]

Some opcodes aren't detected at all:

• movabs{bwlq}
• movz{bwlq}{bwlq}
  • edit: movzbl works, but nothing else
• cmpsb, cmpl, cmpw (cmpq is okay)
• ...

Some opcodes are detected correctly without their final suffix, but aren't when there is the suffix:

• movs{bwlq}{bwlq} (movsb is okay but not movsbq, etc.)
• xadd{bwlq}
• xchg{bwlq}
• dec{bwlq}
• div{bwlq}
• idiv{bwlq}
• mul{bwlq}
• neg{bwlq}
• not{bwlq}
• ...

See: https://docs.oracle.com/cd/E26502_01/pdf/E28388.pdf. I haven't gone through the entire book yet but the rate of opcodes highlighting correctly isn't too high from what I've seen.

Perhaps we want to consider some sort of restructuring of this plugin to catch every opcode? For example, we could list off xadd, xchg, dec, etc. all as opcodes and match op{bwlq} for every opcode, even ones that don't actually support the suffix. Otherwise the database would be really long.

Edit: found this project, which suits my needs. If vim-gas continues to be developed, possibly stealing an idea or two from the linked repo would be a good idea :)

[HealsCodes]

If you’d taken the slightest moment to understand how this plugin works I would have considered taking this serious... but barging in, deciding this is shit and needs a restructuring - where in reality it apparently works for a large number of users - instead of asking “what am I doing wrong?”..

no thanks sir, be happy with whatever plugin you’ve found.

[imyxh]

@Shirk Sorry! I can now see that my comment was a little condescending. Didn't mean for it to come out that way. I just thought this plugin seemed like a good idea and it was missing some ops as far as I can tell. If you're happy with the way this is currenly funtioning, I'll happily close the issue.

I'm also willing to send (or try to write, at least) a PR if you end up being able to verify my issue; the other plugin isn't perfect either.

Thanks for your work!