Health-Informatics-UoN / carrot-mapper

Convenient and Reusable Rapid Omop Transformer.
https://carrot.ac.uk
MIT License
14 stars 4 forks source link

Allow the user to delete the rules file from the downloads #856

Open erummas opened 2 months ago

erummas commented 2 months ago

Is there an existing issue for this?

Is your proposal related to a problem or functionality gap?

No response

Describe your proposal

To ensure only required rules are on the mapper, it would be helpful to allow the user to delete unwanted files from downloads. It will also save space.

Describe alternatives you've considered

No response

I'm part of a Project Team

No response

Anything else?

No response

Are you willing to contribute to developing this feature?

None

AndyRae commented 2 months ago

When I was building this out - I was considering having them deleted automatically after 7/30 days.

We could keep the record of the file being generated in the database (it's not worth the effort to delete it basically), but filter anything older that n days, and just have our storage automatically delete anything.

But yes we'll come round to deleting downloads as well, will be low priority for a while though - we're keen to focus on the core mapping for a bit now.

erummas commented 2 months ago

Sounds good @AndyRae. Yes, definitely not a priority right now.