search

Health-Informatics-UoN / carrot-mapper

Convenient and Reusable Rapid Omop Transformer.
https://carrot.ac.uk
MIT License
14 stars 4 forks source link

Fix Carrot function of building vocabulary from OMOP #890

Closed AndrewThien closed 1 month ago

AndrewThien commented 1 month ago

Changes

This PR fixed the bug that made the "wrong" automatic mapping concepts built from OMOP.

The cause of the bug is the original logic for updating "entries" would loop over the list of available concept relationships (which will be stripping out the duplicated concept relationship) --> only build the first concept correctly and wrongly for the rest if there are many same values in the same SR.

Thanks @AndyRae a lot

Closes #778

Checks

Important: please complete these before merging.

github-actions[bot] commented 1 month ago
Tests Skipped Failures Errors Time
25 1 :zzz: 3 :x: 0 :fire: 4.439s :stopwatch:
dcl10 commented 1 month ago

@AndrewThien, I noticed you ticked the box saying you updated the change log, but you've only changed the code. Are you not doing the change log on carrot anymore? Might be time to sort out the PR template. Maybe to match other DRS projects

AndyRae commented 1 month ago

@AndrewThien, I noticed you ticked the box saying you updated the change log, but you've only changed the code. Are you not doing the change log on carrot anymore? Might be time to sort out the PR template. Maybe to match other DRS projects

Yeah I think we found the changelog annoying and not helpful compared to just using Github with versioned releases. We'll remove it and back to PR templates too