Health-RI / health-ri-metadata

health ri metadata schemas
6 stars 2 forks source link

VCARD shapes are not entirely to spec #113

Closed Markus92 closed 1 month ago

Markus92 commented 1 month ago

While working on SeMPyRO, I've discovered some potential errors in the vcard shapes like they are enforced for dataset. The shape expect it to be a vcard:Kind and the name of the thing in the vcard to be vcard:hasName.

However, the specification and official examples are a bit different: https://www.w3.org/submissions/vcard-rdf/#Class Specifically, they mention a vcard may be a vcard:VCard and the kind is a placeholder for e.g. organization, individual etc.: the kind of thing the vcard is referring to. They also mention that fn is the only mandatory property. In the spec about hasName it looks like it has to do more with specifying the components the name has.

Could y'all please look into this? Thanks!

Markus92 commented 1 month ago

Discussed today with Bruna, Hannah, XiaoFeng and me: the SHACL came from FDP specs and was wrong. We will fix them to conform.

Markus92 commented 1 month ago

Latest version of the VCARD RDF ontology: https://www.w3.org/TR/vcard-rdf/

konradana commented 1 month ago

From looking through the DCAT and vCard documentation I see we indeed need to change vcard:hasName to vcard:fn, since fn is a mandatory property and hasName is used “To specify the components of the name of the object”, so our current use in the model is incorrect. For now I think it’s fine to keep the class name as vCard:Kind and potentially discuss if we want to split it to subclasses (Person, Organization etc.) or assume one of them (ex. All contact points are Organizations) in the next release. For reference, this issue in DCAT-AP GitHub.

xiaofengleo commented 1 month ago

This was discussed in Jira ticket https://health-ri.atlassian.net/jira/software/c/projects/SRP/boards/5?selectedIssue=SRP-541, and resolved in pull request https://github.com/Health-RI/health-ri-metadata/pull/123

kburger commented 1 month ago

Closed by #123 and #124.