search

Health-Sprints / Benchmark

https://vivliostyle.vercel.app/#src=https://health-sprints.github.io/Benchmark/html/index.html&bookMode=true
0 stars 0 forks source link

Doc titles - changes not saving #7

Open mrchristian opened 3 years ago

mrchristian commented 3 years ago

Here is an example

https://write.healthsprints.org/document/546

It could be that we just dont understand the order of how changes should be made.

This is just the type of thing that is needed in a manual, so please add here https://write.healthsprints.org/document/566

johanneswilm commented 3 years ago

I am not sure I am able to reproduce what you are seeing. Testing various times there, the only odd thing is that while making changes in the rest of the editor saves these changes immediately, in the case of the document tile, it is only done on blur (meaning: when you put the focus somewhere else on the page). There is one case where this will lead to the title change not being saved: change the title, then immediately click on "reload" or close the browser tab. This should only affect a small number of test cases, but I will add a fix so that the change to the document title is also saved if the user changes it and then unloads the page.

johanneswilm commented 3 years ago

Please let me know if that is the bug you were seeing.

mrchristian commented 3 years ago

I tried editing using the Anon Browser window. It worked for a few docs and then it stopped working.

See if you can add RKI01 and RKI03 at the start of these documents

https://write.healthsprints.org/document/538

https://write.healthsprints.org/document/568

We have been trying to edit doc titles on two different users on different computers, but both Chrome Win 10.

I'll try on another computer, and try some different browsers.

johanneswilm commented 3 years ago

I have only updating the staging server so far. Does it also happen to you there?

mrchristian commented 3 years ago

Will have a look :-)

mrchristian commented 3 years ago

Works on Staging. With normal browsing on Chrome I have changed the name of 10 files for a Fidus Writer Manual and added FMM at the start of the file names, no problem.

I invited you into the files.

https://staging.fiduswriter.org/

johanneswilm commented 3 years ago

@mrchristian I have now also updated your servers.

johanneswilm commented 3 years ago

@mrchristian I did accept your invite, but I cannot see that I have been added to documents you added there. Did you remove those again or is this simply not yet working? Did you give me access rights to documents or to books?

mrchristian commented 3 years ago

I'll add you now, needed to get you on the system first.

johanneswilm commented 3 years ago

@mrchristian Actually - you shouldn't need to. The system is made so that you can add book and document access rights to an invite BEFORE that person has accepted the invite. Once the person accepts the invite, the book and document access rights should then be transferred to the user automatically.