Closed davecash75 closed 2 years ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
@noxtoby Would it be possible to review this?
Any easy way to review this without having to login to reviewNB?
I think I would just review the notebook as it currently is on the repo and just see if there are any qualms or complaints that you have that I can change. There are going to be a lot of diffs so I don't think ReviewNB would not be too much help. I would just put them in free text in numerous comments rather than tag lines.
Which NB?
adni_ebm.ipynb
or
kde_ebm_walkthrough.ipynb
The latter, I'm going to work on the adni one next.
If you grant me write access, I'll push some corrections
Done cheers!
See this commit
Great! All looks good from my end Neil. Thanks for looking over. If you find anything that I've done with it useful, please feel free to incorporate any of it into the main notebook as you please.
Review was done via email, so all changes incoprorated.
I have taken the original KDE-EBM notebook and tried to tailor it more to introductory Python users. This mainly includes longer variable names and moving the helper functions to another Python script
kde_utils.py
to improve the flow of the document. Once the Pond members accept the invitation, I will tag them on this. When merged this will resolve #5