search

HealthCatalyst / Fabric.Cashmere

Health Catalyst’s comprehensive design system.
http://cashmere.healthcatalyst.net
Apache License 2.0
66 stars 76 forks source link

Date Range Component: Should be able to completely clear out date #1833

Closed corykon closed 2 years ago

corykon commented 2 years ago

When start and end date are optional, it should be possible to clear both dates out and hit apply.

From Guillermo Gomez on Slack

I got excited about the news of the new cashmere release so I was trying to test it in the docs... playing with it in Stackblitz it seems that even when I have both the start and end dates required option marked as false, when I clear the default dates, I get an error when trying to apply my changes (click on the Apply button).

image

@aaronbrethorst any interest in hopping into that code once more?

aaronbrethorst commented 2 years ago

@corykon sure! Happy to take this on. I’m traveling today, but can look at it tomorrow for sure.

health-catalyst commented 2 years ago

:tada: This issue has been resolved in version 12.6.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: