search

HealthCatalyst / Fabric.Identity

Identity service to provide authentication
Apache License 2.0
12 stars 6 forks source link

User/bsmithvt/idpss unavailable bug #278

Closed bsmithvt closed 5 years ago

bsmithvt commented 5 years ago

@michaelvidal24 I'm seeing almost immediate failure when testing with IdP SS unavailable, but I can set an explicit timeout.

michaelvidal24 commented 5 years ago

@bsmithvt - I think the service unavailable is one scenario. But another is if the service is stuck trying to start up and can't respond. The http request will hang waiting for a response, so I think we should try to handle that with a smallish timeout on the http request. Ideally, that timeout would only apply for these specific requests, and not set a shared http client timeout.

bsmithvt commented 5 years ago

@michaelvidal24 ok, good call. I wasn't aware that behavior was different (stopped vs. starting). I've updated the PR to specify an explicit timeout and handle exceptions associated with timeouts.