Moved discovery service installation script into the identity script.

HealthCatalyst / Fabric.Identity

Identity service to provide authentication

Apache License 2.0

12 stars 6 forks source link

Moved discovery service installation script into the identity script. #346

Closed hc-jordenlowe closed 5 years ago

hc-jordenlowe commented 5 years ago

right now, everything is installed altogether. Perhaps I should remove IDPSS and Discovery, then add them to a script separately from identity. That script would call all 3

hc-jordenlowe commented 5 years ago

The new Interface of this install script is:

Install-Identity-Discovery-IdPSS.ps1 and it will have the same switches as Install-Identity.ps1.

There will be 2 config values being added to this:

In discovery service scope, enableOAuth which will install identity first and allow discovery service to talk OAuth to everyone
In Identity scope, useAzureAD will allow Azure AD to be used.

jason-qq commented 5 years ago

One more general comment, if the Discovery install scripts are coming into the identity repo, does the identity install.config need to also have the values from the discovery install.config as well?

hc-jordenlowe commented 5 years ago

One more general comment, if the Discovery install scripts are coming into the identity repo, does the identity install.config need to also have the values from the discovery install.config as well?

They do.

hc-jordenlowe commented 5 years ago

Yah. Having the ability to run the scripts separately and then a master script to combine them makes sense. We have tests for Identity-Utilities and Idpss-Utilities, can we bring Discovery-Utilities tests here as well.

All of the tests are merged into identity's tests.