search

HealthCatalyst / healthcareai-py

Python tools for healthcare machine learning
http://healthcare.ai
MIT License
313 stars 186 forks source link

Dan wellisch transformer breakout 417 #463

Open danwellisch1 opened 6 years ago

danwellisch1 commented 6 years ago

Code to breakout data transformers into individual modules. Nosetests passed.

But in running pylint, there was a coding error uncovered.

E: 33,37: Module 'pandas.core.common' has no 'is_categorical_dtype' member (no-member)

Bad code commented out. Changed code was added. Nosetests don't cover this line of code. Testing of this change is recommended.

Code is not correct: or pd.core.common.is_categorical_dtype(X[c])

or pd.core.categorical.is_categorical_dtype(X[c])

SameerMahajan-GSLab commented 6 years ago

You can pick up my https://github.com/HealthCatalyst/healthcareai-py/pull/476 to fix the issues found here.