search

HealthCatalyst / healthcareai-py

Python tools for healthcare machine learning
http://healthcare.ai
MIT License
309 stars 186 forks source link

Fix failing tests to to column not being datetime. #467

Closed jlitzingerdev closed 6 years ago

jlitzingerdev commented 6 years ago

The existing code initializes a series to integers, and then attempts to set the value to datetimes. This causes the dtype to be object, rather than a date type.

Replace the series generation with a generated list of random timestamps and use that to set the AdmitDTS column.

jlitzingerdev commented 6 years ago

@Aylr Not sure if you want PRs for an Issue like 449, but since you marked it as a bug I thought I'd submit one. If it's helpful I'll iterate until it is good enough, otherwise feel free to close. Note that I wasn't able to view the landscape errors, the server returned a 500 when following the link, so something seems broken on their side.

levithatcher commented 6 years ago

@jlitzingerdev Appreciate this work! Am getting our Appveyor integration fixed, so we can run this through CI--at that point we'll provide direction. Thanks!

levithatcher commented 6 years ago

@jlitzingerdev Might have our CI issues fixed and would love to check your branch. Would you mind adding a space to one of your lines, and re-pushing?

jlitzingerdev commented 6 years ago

@levithatcher No problem! I do apologize that will be later this evening when I get back to my development machine. I'll push, check the CI output and fix any obvious errors. From there I'll wait for feedback.

levithatcher commented 6 years ago

@jlitzingerdev nice, thanks for that small change! Now we see that CI passed here for both Appveyor (windows) and Travis (Linux). I'll merge. Let's talk more soon!

jlitzingerdev commented 6 years ago

@levithatcher Happy to help, cheers.