HealthCatalyst / healthcareai-r

R tools for healthcare machine learning
https://docs.healthcare.ai
Other
245 stars 106 forks source link

breaking changes in recipes #1274

Closed topepo closed 5 years ago

topepo commented 6 years ago

We'll be releasing a new version of recipes in the next week and there are a few breaking changes. See the news file for details. We are trying to get the breaking changes out in one release; some are for upcoming features that aren't implemented yet and we didn't want to stagger them.

The biggest changes are the differences in argument names in the new version, the most significant is new_data instead of newdata in prep.

I've made a fork at https://github.com/topepo/healthcareai-r It isn't passing all tests but I think that those that fail are (probably) unrelated to the recipes changes. A summary of the changes are:

The plan is to send recipes to CRAN next week (I hope) and send caret in once that is accepted. I will alert CRAN that other packages are affected and the maintainers have been notified. I'll update this thread once that process starts.

In the meantime, I could do a PR based on the fork if you are ok with some failures coming along for the ride.

glenrs commented 5 years ago

@topepo Thanks for your help! I attached the PR to the other issue, and it is now merged.