HealthCatalyst / healthcareai-r

R tools for healthcare machine learning
https://docs.healthcare.ai
Other
245 stars 106 forks source link

PR to avoid error with new recipes update #1301

Open EmilHvitfeldt opened 2 years ago

EmilHvitfeldt commented 2 years ago

Hello @mmastand 👋

When doing revdepchecking for https://github.com/tidymodels/recipes/pull/993, I found a couple of bug that appears in your variable type checking code, that used to work before, but now doesn't.

There were also some code that accessed and used the var_info element of a recipe which were causing some problems. Generally we recommend that you don't access elements of a recipe without an accessor function. Thomas wrote this post explaining this problem nicely here https://www.tidyverse.org/blog/2022/09/playing-on-the-same-team-as-your-dependecy/.

I would love to help to give pointers and review PRs that changes the code to avoid using var_info directly.

This PR fixes all the issue! And can be merged now as it isn't dependent on https://github.com/tidymodels/recipes/pull/993.